Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorize.net: certificates added for digicert #5298

Conversation

dawoodmalhi
Copy link
Contributor

Added new certificates since authorize.net is migrating from Entrust to DigiCert.

Reference Article: https://support.authorize.net/knowledgebase/Knowledgearticle/?code=KA-05545
Certificates Source: https://support.authorize.net/knowledgebase/Knowledgearticle/?code=000003009

@dawoodmalhi dawoodmalhi marked this pull request as draft October 10, 2024 06:59
@dawoodmalhi dawoodmalhi marked this pull request as ready for review October 10, 2024 06:59
@dawoodmalhi
Copy link
Contributor Author

@yunnydang can you please review these changes?

Copy link
Contributor

@bradbroge bradbroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 cert already exists in the file, and I'm unclear where the other came from. I'm inclined to deny this change.

lib/certs/cacert.pem Outdated Show resolved Hide resolved
lib/certs/cacert.pem Outdated Show resolved Hide resolved
Copy link
Contributor

@bradbroge bradbroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will plan to merge this either late this week, or early next week. I see that there is a deadline of 23/24th October, we will merge before then.

jonknapp added a commit to CoffeeAndCode/active_merchant that referenced this pull request Oct 20, 2024
@skwidz
Copy link

skwidz commented Oct 22, 2024

@bradbroge Is the plan still to merge this PR before the 23rd?

@bradbroge
Copy link
Contributor

This will be merged tomorrow.

@bradbroge
Copy link
Contributor

nevermind, I can deploy it in the next hour or two 👍🏻

@bradbroge bradbroge merged commit 29158a4 into activemerchant:master Oct 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants